Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DestinationRule docs with correct env variable name #2596

Merged
merged 3 commits into from
Dec 14, 2022

Conversation

brobb7
Copy link
Contributor

@brobb7 brobb7 commented Dec 14, 2022

The Destination Rule documentation show that the verify cert at client environment variable name is VERIFY_CERT_AT_CLIENT in ClientTLSSettings but according to the pilot-discovery docs the environment variable is VERIFY_CERTIFICATE_AT_CLIENT. Updating the Destination Rule documentation to use the correct environment variable name.

@brobb7 brobb7 requested a review from a team as a code owner December 14, 2022 18:09
@istio-policy-bot
Copy link

😊 Welcome @rrobb-aspen! This is either your first contribution to the Istio api repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 14, 2022
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 14, 2022

releaseNotes:
- |
**Fixed** Incorrect pilot-discovery environment variable name.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
**Fixed** Incorrect pilot-discovery environment variable name.
**Fixed** incorrect pilot-discovery environment variable name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this.

@istio-testing istio-testing merged commit bcd542a into istio:master Dec 14, 2022
@brobb7 brobb7 deleted the fix-dr-docs branch December 14, 2022 19:03
@jacob-delgado
Copy link
Contributor

/cherry-pick release-1.16

@jacob-delgado jacob-delgado added the cherrypick/release-1.16 Set this label on a PR to auto-merge it to the release-1.16 branch label Dec 14, 2022
@istio-testing
Copy link
Collaborator

@jacob-delgado: new pull request created: #2597

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing
Copy link
Collaborator

@jacob-delgado: new pull request could not be created: failed to create pull request against istio/api#release-1.16 from head istio-testing:cherry-pick-2596-to-release-1.16: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for istio-testing:cherry-pick-2596-to-release-1.16."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick/release-1.16 Set this label on a PR to auto-merge it to the release-1.16 branch size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants