-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DestinationRule docs with correct env variable name #2596
Conversation
😊 Welcome @rrobb-aspen! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
||
releaseNotes: | ||
- | | ||
**Fixed** Incorrect pilot-discovery environment variable name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
**Fixed** Incorrect pilot-discovery environment variable name. | |
**Fixed** incorrect pilot-discovery environment variable name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed this.
/cherry-pick release-1.16 |
@jacob-delgado: new pull request created: #2597 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jacob-delgado: new pull request could not be created: failed to create pull request against istio/api#release-1.16 from head istio-testing:cherry-pick-2596-to-release-1.16: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for istio-testing:cherry-pick-2596-to-release-1.16."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Destination Rule documentation show that the verify cert at client environment variable name is
VERIFY_CERT_AT_CLIENT
in ClientTLSSettings but according to the pilot-discovery docs the environment variable isVERIFY_CERTIFICATE_AT_CLIENT
. Updating the Destination Rule documentation to use the correct environment variable name.