Skip to content

Proxy config: Add tls_certs_to_watch field #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2019
Merged

Proxy config: Add tls_certs_to_watch field #824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e8fb7f
Proxy config: Add tls_certs_to_watch field
Feb 28, 2019
e727b42
Address PR comment
Feb 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions mesh/v1alpha1/istio.mesh.v1alpha1.pb.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

183 changes: 125 additions & 58 deletions mesh/v1alpha1/proxy.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions mesh/v1alpha1/proxy.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,4 +169,8 @@ message ProxyConfig {

// Tracing configuration to be used by the proxy.
Tracing tracing = 19;

// Absolute path to certs/key files used for istio mTLS. If omitted, defaults to
// /etc/certs/cert-chain.pem,/etc/certs/key.pem,/etc/certs/root-cert.pem
repeated string tls_certs_to_watch = 21;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question : how can you distinguish which is the key/cert file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont. pilot agent simply watches files in that path and if any of them change, it forces envoy to restart

}
6 changes: 6 additions & 0 deletions proto.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1360,6 +1360,12 @@
"id": 19,
"name": "tracing",
"type": "Tracing"
},
{
"id": 21,
"name": "tls_certs_to_watch",
"type": "string",
"is_repeated": true
}
]
}
Expand Down
Loading