Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update membership requirements. #143

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Update membership requirements. #143

merged 1 commit into from
Mar 1, 2019

Conversation

geeknoid
Copy link
Contributor

@geeknoid geeknoid commented Mar 1, 2019 •
edited
Loading

And add the Docs working group.

@geeknoid geeknoid requested a review from linsun March 1, 2019 19:10
@istio-testing
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid

If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@venilnoronha venilnoronha mentioned this pull request Mar 1, 2019
Closed
7 tasks
linsun
linsun approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@linsun linsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Contributor

@linsun: changing LGTM is restricted to assignees, and assigning you to the PR failed.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@linsun linsun merged commit 11b2163 into istio:master Mar 1, 2019
This was referenced Mar 1, 2019
Closed
Closed
Closed
oaktowner pushed a commit to oaktowner/community that referenced this pull request Jul 7, 2020
@geeknoid @oaktowner
Update membership requirements. (istio#143)
263fdd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linsun linsun linsun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geeknoid @istio-testing @linsun