Skip to content

Conversation

gyliu513
Copy link
Member

@istio-testing
Copy link
Contributor

@gyliu513: GitHub didn't allow me to request PR reviews from the following users: morvencao.

Note that only istio members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Fixed issue istio/istio#5701

/cc @linsun @ymesika @morvencao @geeknoid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@linsun
Copy link
Member

linsun commented May 21, 2018

I think this is not needed for new install if you follow the new build that uses proxyv2 as the global image by default.

This should be only needed if users are migrating to 0.8.

@linsun
Copy link
Member

linsun commented May 21, 2018

/lgtm
it doesn't hurt to add it

@istio-testing
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyliu513, linsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 47feea7 into istio:master May 21, 2018
@gyliu513 gyliu513 deleted the bookinfo-envoryv2 branch May 21, 2018 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants