Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mixer-postsubmit fails due to timeout: //pkg/config/crd:go_default_test #633

Closed
gnirodi opened this issue Aug 31, 2017 · 7 comments
Closed

mixer-postsubmit fails due to timeout: //pkg/config/crd:go_default_test #633

gnirodi opened this issue Aug 31, 2017 · 7 comments
Assignees
@gnirodi
Milestone
0.2

Comments

@gnirodi
Copy link
Contributor

gnirodi commented Aug 31, 2017

https://k8s-gubernator.appspot.com/build/istio-prow/mixer-postsubmit/96/

Most likely cause: test size is too big to run. I'm assigning this to sebastienvas@ ++ to investigate how tests like these ought to be structured to avoid becoming too large for testing.

I0831 18:54:25.812] Executed 53 out of 53 tests: 52 tests pass and 1 fails locally.
I0831 18:54:25.812] There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
W0831 18:54:25.815] TIMEOUT: //pkg/config/crd:go_default_test (see /home/bootstrap/.cache/bazel/_bazel_bootstrap/2ba7a783f3c05b4605aea2aadf54c5cd/execroot/com_github_istio_mixer/bazel-out/local-fastbuild/testlogs/pkg/config/crd/go_default_test/test.log)
W0831 18:54:25.815] ____From Testing //pkg/config/crd:go_default_test:
W0831 18:54:25.815] ____Elapsed time: 79.872s, Critical Path: 64.09s
E0831 18:54:25.815] Build failed
@gnirodi gnirodi added the oncall label Aug 31, 2017
@gnirodi gnirodi added this to the Istio 0.2 milestone Aug 31, 2017
@yutongz
Copy link
Contributor

yutongz commented Aug 31, 2017 •
edited
Loading

/assign @chxchx
/unassign @yutongz

@chxchx is this week's engProd oncall

@istio-testing istio-testing assigned chxchx and unassigned yutongz Aug 31, 2017
@sebastienvas sebastienvas assigned gnirodi and unassigned chxchx and sebastienvas Aug 31, 2017
@sebastienvas
Copy link
Contributor

@gnirodi This can be fixed by marking the test as large, or by changing the the test. Please assign this to the creator of the test.

gnirodi added a commit to gnirodi/mixer that referenced this issue Sep 1, 2017
@gnirodi
Fixing post-presubmit failures due to test timeouts. See istio/istio#633
4285716
@jmuk
Copy link
Contributor

jmuk commented Sep 1, 2017

It shouldn't take that much, and so I'm afraid that size="large" wouldn't solve the problem, anyways it would fail. Maybe it's some test flake. I'll check on my side.

@jmuk jmuk mentioned this issue Sep 1, 2017
Merged
istio-merge-robot pushed a commit to istio/old_mixer_repo that referenced this issue Sep 1, 2017
@jmuk @istio-merge-robot
set timeout for waitFor function (#1196)
b8c76ac 
Automatic merge from submit-queue

set timeout for waitFor function

otherwise it could wait infinitely, causing unexpected test timeout.

See istio/istio#633

**Release note**:

```release-note
none
```
@jmuk
Copy link
Contributor

jmuk commented Sep 1, 2017

My PR was merged. I believe this fixes this issue.

@jmuk jmuk mentioned this issue Sep 5, 2017
Closed
@gnirodi
Copy link
Contributor Author

gnirodi commented Sep 5, 2017

Not sure if this entirely fixed this issue: See
https://k8s-gubernator.appspot.com/build/istio-prow/mixer-postsubmit/114/

This is today's post submit in response to:
istio/old_mixer_repo@ed6e995

@jmuk
Copy link
Contributor

jmuk commented Sep 7, 2017

Another fix for this was merged yesterday, so far it seems working. Can we close this?

@sebastienvas
Copy link
Contributor

yes thanks!

rvkubiak pushed a commit to rvkubiak/mixer that referenced this issue Oct 10, 2017
@jmuk @rvkubiak
set timeout for waitFor function (istio#1196)
c0168a1 
Automatic merge from submit-queue

set timeout for waitFor function

otherwise it could wait infinitely, causing unexpected test timeout.

See istio/istio#633

**Release note**:

```release-note
none
```
mandarjog pushed a commit to mandarjog/core3 that referenced this issue Oct 27, 2017
@jmuk @istio-merge-robot
set timeout for waitFor function (#1196)
f7d21ec 
Automatic merge from submit-queue

set timeout for waitFor function

otherwise it could wait infinitely, causing unexpected test timeout.

See istio/istio#633

**Release note**:

```release-note
none
```

Former-commit-id: b8c76ac69927515c15e5ec62f39f89961106fb22
mandarjog pushed a commit to mandarjog/istio that referenced this issue Oct 30, 2017
@jmuk @istio-merge-robot
set timeout for waitFor function (istio#1196)
78a438a 
Automatic merge from submit-queue

set timeout for waitFor function

otherwise it could wait infinitely, causing unexpected test timeout.

See istio#633

**Release note**:

```release-note
none
```

Former-commit-id: e5ca1e99d0c5e3eff81536f1651415f0f635495b
mandarjog pushed a commit that referenced this issue Oct 31, 2017
@kyessenov
Proxy agent: panic after retries, broadcast abort, minor fixes (#633)
db97e0a 
* panic agent

* add desired config arg
howardjohn added a commit to howardjohn/istio that referenced this issue Jan 12, 2020
@howardjohn @istio-testing
Fixes for istiod (istio#633)
72b9496 
* Fixes for istiod

* Fix knative namespace

* Fix clusterrole for cert watch

* Fix lint
howardjohn pushed a commit to howardjohn/istio that referenced this issue Jan 12, 2020
@istio-testing
Provide verbose output during test runs (istio#633)
c964768 
Several people have complained about failed tests during `make update-goldens`.
This PR turns on the verbose flag to aid in debugging both there, as well as `make test`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnirodi gnirodi

Labels
None yet
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
5 participants
@jmuk @chxchx @sebastienvas @gnirodi @yutongz