Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove import of "cmd/pprof/internal/tempfile" #646

Closed
andraxylia opened this issue Sep 2, 2017 · 3 comments
Closed

Remove import of "cmd/pprof/internal/tempfile" #646

andraxylia opened this issue Sep 2, 2017 · 3 comments
Assignees
Milestone

Comments

@andraxylia
Copy link
Contributor

andraxylia commented Sep 2, 2017

e2e tests import internal file, which is disallowed:
"cmd/pprof/internal/tempfile"

Need to use a different API to create a temporary file, so these go pkg can be compiled and tested.

usr/local/go/bin/go test -v -i ./tests/e2e/tests/mixer/...

tests/e2e/framework/framework.go:18:2: use of internal package not allowed

tests/e2e/util/commonUtils.go:18:2: use of internal package not allowed

Process finished with exit code 1

@andraxylia andraxylia added this to the Istio 0.3 milestone Sep 2, 2017
@yutongz
Copy link
Contributor

yutongz commented Sep 3, 2017

Can I confirm you are using go1.9? That package is removed in go 1.9.

@andraxylia
Copy link
Contributor Author

I am using go 1.8. The restrictions about importing internal files precedes go 1.9.
Try to run it locally like this:
go test -v -i ./tests/e2e/tests/mixer/...

@yutongz
Copy link
Contributor

yutongz commented Sep 12, 2017

/unassign @yutongz
/assign @sebastienvas
Oncall transfer

mandarjog added a commit to mandarjog/istio that referenced this issue Oct 30, 2017
Former-commit-id: b7c94a1693f064b87587fe300b1f1ce40df94caf
mandarjog added a commit that referenced this issue Oct 31, 2017
Former-commit-id: 0120f0bcffe8e8d94cf9f077457294bd3da61033
mandarjog pushed a commit that referenced this issue Oct 31, 2017
* first pass http redirect logic for rules

* added unit tests

* added validation test

* added rewrites, updated to lates istio/api commit

* added more validation tests

* added tests for rewrite

* formatting fix

* expanded rewrite test case
howardjohn pushed a commit to howardjohn/istio that referenced this issue Jan 12, 2020
…tio#646)

* Disable leader election when LEADER_ELECTION_NAMESPACE is not set

Debugging the controller is practically impossible, since it loses
the leader election lock when it's suspended for too long. This causes
the process to be terminated.

* Improve warning
0x01001011 pushed a commit to thedemodrive/istio that referenced this issue Jul 16, 2020
* SE spiffe ID

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* more updates

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* nits

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* combined updates

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* combined updates

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* nits

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* nits

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* nuke san from dr

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* auto passthrough

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* remove san from service entry

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
luksa pushed a commit to luksa/istio that referenced this issue Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants