Migrate code to use IstioOperator API in istio/api #713
Conversation
googlebot
added
the
cla: yes
istio-testing
added
needs-rebase
istio-testing
removed
the
needs-rebase
| 1. [Manifest creation](#manifest-creation) code. User settings are overlaid on top of the | ||
| selected profile values and passed to a renderer in the Helm library to create manifests. Further customization on the | ||
| created manifests can be done through overlays. | ||
| 1. [CLI](#cli) code. CLI code shares the `IstioControlPlaneSpec` API with | ||
| 1. [CLI](#cli) code. CLI code shares the `IstioOperatorSpec` API with |
There was a problem hiding this comment.
Dumb question now, but isn't this used for istioctl as well?
data/profiles/demo.yaml
Outdated
| @@ -1,67 +1,60 @@ | |||
| apiVersion: install.istio.io/v1alpha2 | |||
There was a problem hiding this comment.
if we are changing the API don't we need to increment the api version?
There was a problem hiding this comment.
Actually this is a brand new API - just updated PR to reflect that.
README.md
Outdated
| K8s settings like resources, auto scaling, pod disruption budgets and others defined in the | ||
| [KubernetesResourceSpec](https://github.com/istio/operator/blob/905dd84e868a0b88c08d95b7ccf14d085d9a6f6b/pkg/apis/istio/v1alpha2/istiocontrolplane_types.proto#L411) | ||
| [KubernetesResourceSpec](https://github.com/istio/api/blob/7791470ecc4c5e123589ff2b781f47b1bcae6ddd/mesh/v1alpha1/component.proto#L103) |
There was a problem hiding this comment.
nit: can you point the link to master instead
istio-testing
added
the
needs-rebase
istio-testing
removed
the
needs-rebase
istio-testing
added
the
needs-rebase
There was a problem hiding this comment.
@ostromart is it ready for review again? Hope this PR can be merged soon first to unblock other PRs.
|
/retest |
| @@ -1,18 +1,4 @@ | |||
| apiVersion: install.istio.io/v1alpha2 | |||
There was a problem hiding this comment.
Shouldn't the apiVersion be operator.istio.io/v1alpha1?
| @@ -1,18 +1,38 @@ | |||
| apiVersion: install.istio.io/v1alpha2 | |||
There was a problem hiding this comment.
also here, should be operator.istio.io/v1alpha1?
|
we should block the master from merging other PRs before we merge this one. |
|
@ostromart: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
See the corresponding API change:
istio/api#1223