-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bazel usage from the repo #1580
Comments
@howardjohn - I can help with this. Depending on the particular |
Since #1631, it would appear It would be nice to come to a compromise of if or to what extent we want to use |
That is exactly why I created #1635, to remove the BUILD.bazel files as they are actively misleading. This change was blocked. |
istio/proxy does, but it's still OK to remove bazel from istio/test-infra. But let's definitely not remove bazel from istio/proxy ;) |
Bazel was used for 2 + years and nobody complained. I find it really sad. the time gained when working with docker images, and daily workflows for me is priceless. Anyways I am doing one or two contribution a month to fix stuff, so I may not be the standard user. I think @fejta has made some bazel contrib in the last months so He may have more context. |
I am opposed to removing bazel usage from this repo |
Given kubernetes/kubernetes#99561 this seems to be where upstream is moving? Unless k/test-infra will still use bazel |
That KEP expressly covers only github.com/kubernetes/kubernetes. Sub-projects will continue to use their preferred tools. I don't think there's currently a movement to change any other repos. |
Ack, thanks Ben. |
No other repo in istio uses bazel. As far as I know there is no reason we need bazel here, and it makes the repo unfamiliar for Istio contributors.
If possible we should remove bazel.
I am not familiar enough with bazel to know how feasible this is and if its as simple as
rm all_bazel_stuff
and replacebazel test
withgo test
, etcThe text was updated successfully, but these errors were encountered: