Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix authorship attribution #2464

Merged
merged 1 commit into from
Mar 5, 2020
Merged

fix authorship attribution #2464

merged 1 commit into from
Mar 5, 2020

Conversation

clarketm
Copy link
Member

@clarketm clarketm commented Mar 5, 2020

This is a solution for: kubernetes/test-infra#16618 where authorship attribution is given to the bot and not the PR author for merge squash commits.

https://help.github.com/en/github/committing-changes-to-your-project/creating-a-commit-with-multiple-authors

Screen Shot 2020-03-05 at 12 37 32 AM

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 5, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 5, 2020
@clarketm clarketm force-pushed the author branch 2 times, most recently from 41be9d9 to 9859bb6 Compare March 5, 2020 08:45
@clarketm clarketm changed the title fix missing authorship attribution fix authorship attribution Mar 5, 2020
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really annoying. I think its a github bug.. look at https://github.com/envoyproxy/envoy/commits/master, thats not even a robot its just Matt pressing "merge" on github and its accredited to him. I sent a ticket to github, not sure if it will change anything

Thank you very much for fixing this, this was bugging me a lot!

@istio-testing istio-testing merged commit 127d239 into istio:master Mar 5, 2020
@istio-testing
Copy link
Collaborator

@clarketm: Updated the config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file prow/config.yaml

In response to this:

This is a solution for: kubernetes/test-infra#16618 where authorship attribution is given to the bot and not the PR author for merge squash commits.

https://help.github.com/en/github/committing-changes-to-your-project/creating-a-commit-with-multiple-authors

Screen Shot 2020-03-05 at 12 37 32 AM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@clarketm clarketm deleted the author branch March 5, 2020 22:15
@clarketm clarketm restored the author branch March 6, 2020 08:46
clarketm added a commit that referenced this pull request Mar 6, 2020
istio-testing pushed a commit that referenced this pull request Mar 6, 2020
Co-authored-by: clarketm <clarketm@users.noreply.github.com>
@clarketm clarketm deleted the author branch March 7, 2020 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants