Skip to content

Conversation

danielgtaylor-isp
Copy link

Currently events ignore tags set on the metrics client. This fixes that bug by modifying the event with the configured tags on the client before sending.

@danielgtaylor-isp danielgtaylor-isp self-assigned this Feb 28, 2018
@danielgtaylor-isp danielgtaylor-isp requested a review from a team February 28, 2018 23:25
@codecov-io
Copy link

codecov-io commented Feb 28, 2018

Codecov Report

Merging #5 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage    94.8%   94.83%   +0.03%     
==========================================
  Files           6        6              
  Lines         327      329       +2     
==========================================
+ Hits          310      312       +2     
  Misses         12       12              
  Partials        5        5
Impacted Files Coverage Δ
metrics/datadog.go 94.59% <100%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5238649...faa7a02. Read the comment docs.

Copy link

@dcaiafaISP dcaiafaISP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielgtaylor-isp danielgtaylor-isp merged commit 27b35e9 into master Mar 1, 2018
@danielgtaylor-isp danielgtaylor-isp deleted the event-tags branch March 1, 2018 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants