recommended clarifications #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alan-Cha
reviewed
Oct 31, 2023
| Once both backend versions are responding to requests, the output of the load generator will include recommendations from the candidate version. In this example, you should see something like: | ||
|
|
||
| ``` | ||
| Recommendation: {"Id":19,"Name":"sample","Source":"backend-candidate-1-56cb7cd5cf-bkrjv"} |
There was a problem hiding this comment.
I think you should say that it will be a mix and also show some output that looks like a mix, not just a single recommendation.
Signed-off-by: Michael Kalantar <kalantar@us.ibm.com>
Signed-off-by: Michael Kalantar <kalantar@us.ibm.com>
Signed-off-by: Michael Kalantar <kalantar@us.ibm.com>
Alan-Cha
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.