Skip to content

Conversation

sriumcp
Copy link
Member

@sriumcp sriumcp commented Feb 18, 2022

No description provided.

Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
@sriumcp sriumcp mentioned this pull request Feb 18, 2022
@sriumcp
Copy link
Member Author

sriumcp commented Feb 18, 2022

@kalantar This PR fixes your comments ...

Some observations:

Re: gen and run....

  1. gen is now a hidden command. launch --dry essentially uses gen and stops at that stage. launch also invokes run. From an end-user point of view, there is no gen, only launch --dry.

  2. run now runs experiment.yaml. So, --set and -f are no longer options for run. I think run is very useful for development purposes, which is the main reason for not hiding it. End-users get launch, which is what they will see in all the tutorials.


Also, let us continue any further discussion through this PR (as usual) instead of the issue based discussion (which was temp).

Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
@sriumcp sriumcp merged commit f5b574f into iter8-tools:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant