-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cases: Versioning Data and Model Files (review) #1716
Conversation
fde3b1a
to
7d13ab2
Compare
content/docs/use-cases/versioning-data-and-model-files/index.md
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
To be honest I don't see any major changes. What I would expect is that we go at least one level up in terms of how we explain this use case. It is still very technical, with exact commands, etc. We should migrate this into tutorials, how-tos |
This comment has been minimized.
This comment has been minimized.
BTW, based on https://documentation.divio.com/introduction/ Use Cases are not fully documentation... They are part Explanation I guess, and they can contain some How-to steps (in fact the Shared Cache one is one of our most popular "tutorials", I think). But they're also 50% marketing, closer to our current https://dvc.org/features page sections. May be interesting to pull them out of /docs, even merge with /features perhaps. Moving the How-to parts to the actual /how-to docs of course (and link from the use case). This would make them proper landing pages (possibly with their own design, even). |
3944d9c
to
7b550fc
Compare
I simplified the intro and DVC is not Git! sections of the use case. See https://dvc-landing-use-cases-iezica0y.herokuapp.com/doc/use-cases/versioning-data-and-model-files. The rest of the content was also updated but it will need to be migrated like you mentioned, and just briefly mentioned//linked to the new location. However that's also the case for all other use cases including Data Registries, and depends a little on having started the How-to section (in progress, see #899).
I also improved mentions of the versioning case and it's tutorials throughout the docs. |
Per call with Ivan, we'll use this same PR to try and simplify the 2nd half of the Versioning use case, moving low-level code blocks to its tutorial... ⏳ |
335b71a
to
1dd8ac4
Compare
1dd8ac4
to
d224c98
Compare
@jorgeorpinel good progress, but overall I feel that we moved 0.5 level, not 1 👍 What I would expect to see to make my feedback more actionable:
I guess, my point is that most likely we would need to write a new doc, not edit the existing one, to actually move +1 level. |
Understood. I'll work on rewriting it completely then ⏳ Should we merge this for now? |
explain why versioning large files is important/a thing per #1716 (comment)
explain why versioning large files is important/a thing per #1716 (comment)
explain why versioning large files is important/a thing per #1716 (comment)
Or should we close it in favor of #1747 ? |
@jorgeorpinel not sure I can recommend on this to be honest, it depends on your flow. From my end, it would be great to have a single PR. |
I think this one is done. Maybe it's not what we need but if it's an improvement and you found no errors, etc. then I would like to merge it. But we can also close it since it will be overwritten by the other PR at some point, hopefully soon. |
Fine, we can merge it!
I didn't look for errors to be honest, was not reviewing it to deep since to my mind we need to redo this case on a different level. |
OK thanks! I think it's good to merge this because people are reading it and it's quite outdated. |
* cases: [WIP] befin rewriting Versioning: explain why versioning large files is important/a thing per #1716 (comment) * cases: give some sense of why versioning data and models is important per #1747 (comment) * guide: why DVC is the way to Version data (sell philosophy) per #1747 (comment) * cases: add example section explaining why data versionig is is important, and how it looks with DVC per #1747 (comment) * cases: wrap up Versioning full draft * cases: rename demo section in Versioning, roll back checkout img, et al. * cases: some more versioning updates * cases: shorten versioning intro * cases: add bullet list of Versioning advantages per #1747 (comment) * cases: shorten Why DVC section in Versioning * term: data modeling -> data engineering per #1747 (review) * cases: make advantages section in Data Registry (consistency) * cases: make separate Versioned storage section * cases: rewrite intro and other changes to Versioning per #1747 (comment) * cases: cover gap between Versioning and (remote) storage, link to GS also per #1747 (comment) * use-cases: reapply SEO keyword changes from #1806 > Add "data and model versioning", "versioning (large) data files", and "model versions" * cases: make p about storage less overlapping to previous one per #1747 (review) * cases: add paragraph about versioning advantages before DVC's motivation per #1747 (review) * cases: simplify lists of advantages in Versioning (and Data Reg) rel #1747 (review) * cases: limitation->constraint (to avoid a redundancy) * guide: move DVC is not Git! from use cases to What is DVC? rel #1747 (review) * cases: ~~Summary of~~ Advantages (H2) * cases: rewrite parts of the DVC motivation paragraphs in Versioning * cases: improve vrsng intro and dedupe bullet lists * cases: rename Advantages sectino of vrsng per #1747 (review) * cases: expand on How it looks (vrsng) with focus on workspace per #1747 (review) * guide: improve DVC is not Git! section per #1747 (review) * cases: rename Versioning use case (why "Files"?) per #1747 (review) * cases: rewrite (again) the intro to vrsng per #1747 (comment) * cases: improve versioning intro (more coherent) * cmd: quick term update * cases: update links to Versioning use case * cases: refine Versioning intro, add proposed figure * cases: summarize, simplify, focus on the essence, et al. and propose new "Versioned storage" use case * cases: add redirect for new Versioning use case location * cases: merge How it looks + Version control sections * cases: simplify versioning-data-and-models#how-it-looks * Revert "redirect for new Versioning use case URL" 12bc7ed and put back the files and nav * cases: rewrite intro to improve motivation and post a draft figure proposal * cases: update Why DVC and benefits list based on https://docs.google.com/document/d/1jmvbsRC2JhzqAF0eTGu0tX9ydMNndiBviCHq5ezzfEY/edit * cases: actually revert URL change from recent commit * cases: more updates to the benefits bullets in Versioning * cases: rewrite How it looks (& feels) section * cases: remove non-essential info. from How it looks section of Versioning (a little aggressive) * cases: simplify How it looks per David and some of Ivan's feedback (remove cache mentions) * cases: remove H2s temporarily, simplify benefits bullet list, et al. * cses: rewrite benefit bullets and simplify how it feels section * cases: make bullet list into paragraph temp. * cases: wrap up Vrsng? (text) * cases: hardcode colums in How it feels section of Vrsng * cache: simplify it's structure explanation and add CAS term (from Vrsng use case) * guide: revert changes to this section for now * cases: polish latest iteration of Versioning use case * cases: next iteration of Versioning page per private feedback. Some issues may still be outstanding, will send smalles commits next * cases: polishing my last iteration of the Vsng page * remove a bunch of info from Vrsng to simplify again * cases: minor iteration of Vrsng, pending benefits list * guide: updates to What is DVC per #1747 (review) and #1747 (review) * cmd: roll-back unrelated changes (stashed elsewhere for now) per #1747 (review) and #1747 (review) * cases: work on benefits of Vrsng * cases: more work on benefits of Vrsng * cases: remove emojis; improve benefits list; add refs to other cases * cses: clarify about cache and about metafiles in Versioning * cases: simplify p about roll back/fwds; split benefit about data regs * cases: change BEFORE to be similar to the top fig. * cases: another iteration of Versioning * cases: simplify Versioning again * cases: improvements on Vrsng per direct feedback * cases: more updates to latest text and figures * cases: rephrase Vrsng benefits list * cases: revert to previous draft fig * cases: update 2nd figure draft, and reorder codification p * cases: rework Vrsng benefits and other small improvements and removed advanced topics (for a new section coming up) * cases: draft What's Next section added with advanced scenarios for Vrsng * cases: simplify 2nd figure * cases: make first Vrsg figure shorter * cases: merge advanced scenarios with benefits list * cases: roll back changes to Data Regs per https://github.com/iterative/dvc.org/pull/1747/files#r515533725 * cases: improvements per Dmitry's feedback... see #1747 (review) * cases: train_feats > features in figures for Vrsng * cases: rename Vrng Tutorial label in nav (use emoji) * cases: explain simple file naming a bit more per #1747 (comment) * cases: Vrng copy edits * cases: add efficient data mgmt benefit per #1747 (comment) * cases: reorder Vrsg benefits list per #1747 (comment) * cases: rewrite file naming and data mgmt benefits of Vrsg * cases: expand story to cover storage and data management and update benefits * cases: generalized Vrsg benefits * cases: separate data mgmt from versioning (through codification) in Vrsg * Make note about other guides, refs, and tutorial (Vrng) * cases: emphasize Simplicity benefit of Vrng is the opposite of "complicated" * cases: another rewrite of text and benefits * cases: copy edits to latest Vrng iteration, and append next steps paragaph (bottom) * cases: another iteration of Versioning use case * cases: clarify data mgmt is for data in Vrng benefits
Addresses #820
Extract How-to steps into actual how-to guide? (hidden for now, see guide: begin How To section #1705)Extracted to cases: extract how-to/tutorial parts into separate pages #1722