Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd: update commit-related info. #1989
cmd: update commit-related info. #1989
Changes from 3 commits
5f5c1ff
68c9c1a
94eb1f8
9c22f7e
45da240
9b06323
6ba7ea0
98c464f
a0cb751
ba6e109
3711dc8
ce8ccad
1c7d4a1
0be1fe0
f63a664
12a1a8e
97be1b9
144749f
859e874
cf34cf6
11c2768
36997ed
b45e324
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure
Other
applies here? it's more like a detailed explanation?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm they're meant as different scenarios. The part before this is about
add/run/repro --no-commit
+dvc commit
— main use case. The bullets in this list aredvc add *
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of them (all of them?) are part of the main use case in this terminology.
add/run/repro --no-commit
is not even a use case by itself, right? it doesn't explain a specific need.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the main reason
commit
exists as a stand-alone command is to complement the--no-commit
options of add/run/repro?In terms of the "story", its explained as "forces DVC to accept the contents of tracked data currently in the workspace" in the first p of the description. So do you mean they're all different flavors of that explanation and that there should be a single bullet list (including
add/run/repro --no-commit
)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably initially it was the case, now we reference it in other places? (like
--no-exec
?) So we might need to revisit, generalize? (not 100% sure, just asking)it seems so (not sure about all)
ah, not necessarily. Just removing Other might help? or rephrasing it a bit if the first paragraph is already general.
again, not very constructive feedback here - just highlighting stuff as I read it, a think that seemed strange
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. I iterated on this to make clear that the first p is a generalization, then a main scenario is explained, and finally a list with other scenarios. PTAL.