Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Info about VS Code Extension #3651

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Add Info about VS Code Extension #3651

merged 3 commits into from
Jun 14, 2022

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Jun 13, 2022

  • Adds VS Code to header and footer
  • Updates Banner
  • Updates /features

@shcheklein shcheklein temporarily deployed to dvc-org-add-vscode-dalemcda96m June 13, 2022 23:29 Inactive
@julieg18 julieg18 self-assigned this Jun 13, 2022
@julieg18 julieg18 temporarily deployed to dvc-org-add-vscode-dalemcda96m June 13, 2022 23:45 Inactive
@julieg18 julieg18 requested a review from a team June 14, 2022 00:01
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Jun 14, 2022

Indirectly related, but why do we list DVC under "other tools"?

image

image

May be good to remove that now that the list is getting longer.

@jorgeorpinel
Copy link
Contributor

Should use consistent icon/logo I think (including the external link icon on hover).

image

image

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Jun 14, 2022

Seems too prominent in /features? No strong opinion as that whole page is in need of redesign anyway...

image

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some design questions but should work IMO. Thanks @julieg18

@jorgeorpinel
Copy link
Contributor

p.s. did we decide not to put it in the Download button after all?

@yathomasi
Copy link
Contributor

Indirectly related, but why do we list DVC under "other tools"?

I think it would be better to have all the tools in the same place. Maybe we can rename it to "our tools". If we add more tools then we can reorganize them into multiple columns.

@jorgeorpinel
Copy link
Contributor

Maybe we can rename it to "our tools"

Agree.

@julieg18
Copy link
Contributor Author

Seems too prominent in /features? No strong opinion as that whole page is in need of #144 (comment) anyway...

Agreed! We originally just wanted to add another feature to the list but it looked odd with uneven rows, which is why we chose to just put more focus on it as a top feature. We could discuss other options, but this is going to be merged in about an hour 😅 And as you already mentioned, we'll be refactoring this whole page in the future!

p.s. did we decide not to put it in the Download button after all?

Yes, maybe we'll add it in the future, but it's not needed for the release.

Should use consistent icon/logo I think (including the external link icon on hover).

Maybe! I don't see why the footer/nav would need to match besides the logo though... Footers don't typically have special animation/effects added to them... As for logo, we could move the links to have the VSC link to be right under DVC without a logo as well but it will need to be in a follow-up pr.

Indirectly related, but why do we list DVC under "other tools"?
I think it would be better to have all the tools in the same place. Maybe we can rename it to "our tools". If we add more tools then we can reorganize them into multiple columns.

Good idea! I can change the naming in a follow-up pr :)

@julieg18 julieg18 merged commit dafed10 into master Jun 14, 2022
@julieg18 julieg18 deleted the add-vscode branch June 14, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants