-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Info about VS Code Extension #3651
Conversation
Seems too prominent in /features? No strong opinion as that whole page is in need of redesign anyway... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some design questions but should work IMO. Thanks @julieg18
p.s. did we decide not to put it in the Download button after all? |
I think it would be better to have all the tools in the same place. Maybe we can rename it to "our tools". If we add more tools then we can reorganize them into multiple columns. |
Agree. |
Agreed! We originally just wanted to add another feature to the list but it looked odd with uneven rows, which is why we chose to just put more focus on it as a top feature. We could discuss other options, but this is going to be merged in about an hour 😅 And as you already mentioned, we'll be refactoring this whole page in the future!
Yes, maybe we'll add it in the future, but it's not needed for the release.
Maybe! I don't see why the footer/nav would need to match besides the logo though... Footers don't typically have special animation/effects added to them... As for logo, we could move the links to have the VSC link to be right under DVC without a logo as well but it will need to be in a follow-up pr.
Good idea! I can change the naming in a follow-up pr :) |
/features