-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add troubleshooting guide #875
Conversation
@jorgeorpinel @pared let's create a user guide Troubleshooting section. I don't like this duplication and complication of the command reference. We can create a separate page per error, or for now a single page with expandable blocks or h2 segments. |
This comment has been minimized.
This comment has been minimized.
@shcheklein my initial #871 (comment) was
We have several of these repeated notes, paragraphs, sentences in different docs already, especially command references. It makes sense since there's overlap in functionality or implementation details in many places. I don't think we need a Common problems section though, since there's only one and can't foresee having others in the immediate future. Maybe just add the paragraph in the bottom of the Description section? Starting with "A known issue..." |
It looks like it does not, right? at least it'a big paragraph already :) And it would be an artificial constraint to try to keep error explanations like this very short. also, this is an edge case, it's not that important to include it into description for all commands (3 places at least?)
they are usually small, there are not so many of them, and it might be a problem for some of them that they are repeated. And to my point above - they are usually general enough and highlight some important workflow (like installing S3 with DVC), they do not serve as an explanation of an error code.
I like Troubleshooting as the name, someone has used it already in some comment - it makes sense to me :)
I can easily add a few :)One of the most commons - what should I do when I get "DVC is busy" message. There will be more and more as we move forward and improve interface. |
To be clear, I'm not opposed to this. It's a good option, and just link from these command refs. BTW @pared please notice my other #871 (comment) in the issue:
Indeed, it's a long one even, my shorter version. Would be nicer to split it in 2.
Yes, I like it too. Or/and Known issues |
I would say: |
Agree. This file descriptor thing to me sounds like an issue that could have a code solution to me. Not sure though. |
@jorgeorpinel yes, it is solvable, and this change is taking some time because we were discussing it a lot with @efiop and @Suor. Some of the conclusions can be found at The conclusion was that we want to preserve quite high default value of |
@jorgeorpinel @shcheklein I created |
d4fcdbe
to
350b2db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few improvement requests.
You also need to update the sidebar.json
file to make this section active. See the contributing guide - it should include the instruction, I believe. I would recommend running this locally to test it.
Thanks for all the context @pared! So, my point was that this may not be a "trouble" the way @shcheklein described it, but in fact a "known issue". I think you're confirming this? |
@jorgeorpinel @pared if agree on it to be a "known issue" then we don't need this doc - let's open ticket in the Github DVC repo with a description, workaround, ETA on solving, etc. I don't think we need document this things. To me the current solution is a first iteration, but a solution - thus I was thinking this documentation makes sense and should be part of the troubleshooting. |
To be or not to be! (A known issue) That is the question. I like the "regular workflow, you just hit bumps" argument but not sure it's accurate. I have to yield to you guys in the end to decide what this thing is. But I think Ivan is right that a fully described issue on GH would be enough for "known issues". Maybe @efiop or @Suor (mentioned before) have comments on this? |
k, to be more precise :) |
…oting guide header per iterative#875 (comment)
@shcheklein @jorgeorpinel updated the address in docs, also the |
Thanks @pared. There's just this one matter to decide definitely on, I think: #875 (review) please weight in if you can 🙂
|
and refactor redirect code for consistency with existing ones per iterative#875 (review)
…for troubleshooting header per iterative@d5340e6#r36802142
Shortened nav title to just "Troubleshooting" See https://dvc-landing-2473-amnjganfpaic8.herokuapp.com/doc/user-guide/troubleshooting Opened web: enable custom anchor id/href for troubleshooting guide? #922 |
Disregard the recommendations below if you use Edit on GitHub button to improve the docs in place.
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue
(if applicable) in the description of the PR. This enables GitHub to link the PR to the corresponding bug and close it automatically when PR is merged.Thank you for the contribution - we'll try to review and merge it as soon as possible. 🙏
Fixes #871