-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
p3-nice-to-haveIt should be done this or next sprintIt should be done this or next sprintrefactoringFactoring and re-factoringFactoring and re-factoringtestingRelated to the tests and the testing infrastructureRelated to the tests and the testing infrastructure
Description
In our test base, TestDirFixture.CODE
copies src to target. It can cause problem if one decides to write a test like:
dvc_repo.add(repo_dir.FOO)
metric_file = "metric.txt"
dvc_repo.run(
deps=[repo_dir.FOO],
metrics_no_cache=[metric_file],
cmd="python {} {} {}".format(repo_dir.CODE, repo_dir.FOO, metric_file),
)
In this case metric is not supposed to be in cache. But due to fact that it is identical as repo_dir.FOO
it is inside cache, so we might end up "finding" it for example here. Which can lead to some unexpected behaviour.
Currently, there is no test using CODE to create metric, so I would not prioritize this task, though we should do something to discourage or prevent this use case.
efiop
Metadata
Metadata
Assignees
Labels
p3-nice-to-haveIt should be done this or next sprintIt should be done this or next sprintrefactoringFactoring and re-factoringFactoring and re-factoringtestingRelated to the tests and the testing infrastructureRelated to the tests and the testing infrastructure