Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: make exp_show return float instead of None for zeroes #10034

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

dberenbaum
Copy link
Contributor

Handles zeroes in dvc.api.exp_show(). See the bar column for the tawie-purl below.

Before this PR:

>>> import pandas as pd
>>> from dvc.api import exp_show
>>> pd.DataFrame(exp_show())
   Experiment        rev          typ   Created parent State Executor  foo   bar
0        None  workspace     baseline      None   None  None     None  NaN  None
1        None       main     baseline  12:16 PM   None  None     None  NaN  None
2  tawie-purl    6b6cf80  branch_base  02:40 PM   None  None     None  1.0  None

After this PR:

>>> import pandas as pd
>>> from dvc.api import exp_show
>>> pd.DataFrame(exp_show())
   Experiment        rev          typ   Created parent State Executor  foo  bar
0        None  workspace     baseline      None   None  None     None  NaN  NaN
1        None       main     baseline  12:16 PM   None  None     None  NaN  NaN
2  tawie-purl    6b6cf80  branch_base  02:40 PM   None  None     None  1.0  0.0

@dberenbaum dberenbaum requested a review from a team October 18, 2023 19:21
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
dvc/api/experiments.py 100.00% <100.00%> (+8.33%) ⬆️
tests/func/api/test_experiments.py 100.00% <100.00%> (ø)

... and 48 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@dberenbaum dberenbaum self-assigned this Oct 30, 2023
@dberenbaum dberenbaum enabled auto-merge (rebase) October 30, 2023 18:23
@dberenbaum dberenbaum merged commit fc51477 into main Oct 30, 2023
21 checks passed
@dberenbaum dberenbaum deleted the api-exp-show-0 branch October 30, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants