-
Notifications
You must be signed in to change notification settings - Fork 1.2k
dvc: add support for dvc diff command #1778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dvc/scm/git/__init__.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b_commit = ... a_ref looks pretty strange :) That's why I would probably just name params just --ref
.
@shcheklein, @efiop Guys take a look, and we still need to discuss the CLI syntax. |
@django-kz I don't think your patch works:
prints
which doesn't seem right. Or am I missing something? |
@efiop Actually, here it shows what changes happened from your current ref and specified one, I mean I expect it to work that way, so it is not a bug, it is a bad design ) |
@django-kz Also, please take a look at codeclimate report. It has some really good points in it. |
Getting git snapshots of file/directory using GitTree object
repo.diff now returns list of dictionaries for each file/directory change
Now the dvc diff reference command will return the difference betweent from specified commit to current HEAD.
Thanks! 🎉 Mind also adding a simple command reference to dvc.org? E.g. see iterative/dvc.org@6406bb8 as an example. Or, at least add an issue for it to dvc.org issues. |
@django-kz Also, please don't forget to at least add those "TODO"s as issues to https://github.com/iterative/dvc/issues . |
Some summary statistics regarding the folder/file.
How many files were added/deleted/modified. How the size was changed.
TO DO things:
1)To add support for detecting diff after
dvc move
command.
2)To add unit tests.