cache: test: allow cache to be on different drive #2000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pared
force-pushed
the
1976
branch
3 times, most recently
from
989dcaa to
987d6da
Compare
pared
changed the title
efiop
reviewed
May 14, 2019
efiop
reviewed
May 14, 2019
efiop
reviewed
May 14, 2019
dvc/path/local.py
Outdated
There was a problem hiding this comment.
Hm, still catching ValueError here seems too much, since it is only relevant for windows and ValueError could be raised in a lot of cases. Maybe it is worth checking for it separately before trying to relpath()?
There was a problem hiding this comment.
Btw, just a note: that check and relpath itself might cause quite a performance hit, as we've learned from cProfile a long time ago, so the plan was to make PathLOCAL do some caching in the future, so it doesn't have to recompute that again and again. But maybe there is a better approach.
efiop
reviewed
May 14, 2019
tests/conftest.py
Outdated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you followed the guidelines in our
Contributing document?
Does your PR affect documented changes or does it add new functionality
that should be documented? If yes, have you created a PR for
dvc.org documenting it or at
least opened an issue for it? If so, please add a link to it.
Fixes Error with "dvc add" on Windows, when local cache is not on the same drive as git repo #1976