Skip to content

update zsh autocomplete script with current command help messages + #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 30, 2019
Merged

update zsh autocomplete script with current command help messages + #2064

merged 4 commits into from
May 30, 2019

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented May 29, 2019 •
edited
Loading

  • Have you followed the guidelines in our
    Contributing document?

  • N/A Does your PR affect documented changes or does it add new functionality
    that should be documented? If yes, have you created a PR for
    dvc.org documenting it or at
    least opened an issue for it? If so, please add a link to it.

As identified in #2003 (comment)

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented May 29, 2019 •
edited
Loading

@efiop @MrOutis please note a couple tests are not passing but this was already the case before my changes. Try them in the upstream master (currently on commit 500a26e):

python -m tests tests/func/test_data_cloud.py::TestDataCloud::test tests/unit/remote/test_oss.py::TestRemoteOSS::test_init

@jorgeorpinel jorgeorpinel mentioned this pull request May 29, 2019
Closed
jorgeorpinel
jorgeorpinel commented May 29, 2019
View reviewed changes
@efiop efiop requested review from a user and pared May 29, 2019 06:02
pared
pared approved these changes May 29, 2019
View reviewed changes
@jorgeorpinel jorgeorpinel mentioned this pull request May 29, 2019
Closed
2 tasks
efiop
efiop suggested changes May 30, 2019
View reviewed changes
@jorgeorpinel
dvc: fixes dvc.scm.Git.get_diff_trees docstring imprecision.
25e89f0 
Parentheses were used in the "Returns:" description but its a dict, so changed to curly brackets;
and specified the 2 possible forms of the return structure.
@jorgeorpinel
dvc: updates zsh autocomplete script with current command help messages.
d66b451 
Comparing vs actually running each command's `-h` help output.
@jorgeorpinel
dvc: begins updating bask autocomplete script...
9dde091 
Only reorders existing commands and adds comments for those missing.
@jorgeorpinel
scripts: removes temporary comments in bash autocomplete script.
bcc92ab 
Per #2064 (review)

Related to #2069
efiop
efiop approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙂

@efiop efiop merged commit 8df0712 into iterative:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shcheklein shcheklein shcheklein left review comments

+2 more reviewers

@efiop efiop efiop approved these changes

@pared pared pared approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jorgeorpinel @shcheklein @efiop @pared