makedirs: fix mode flag is being ignored starting from Python 3.7 #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shcheklein
requested review from
pared and
a user
and removed request for
efiop
pared
reviewed
Nov 14, 2019
|
One comment, also test for 2.7 fails. I tried to reproduce it on my computer, and it seems to fail only for first test run. Maybe something is not unset? Though its done in finally, so I am confused. |
π |
pared
reviewed
Nov 15, 2019
ghost
approved these changes
Nov 15, 2019
|
@MrOutis yep! thanks
yep, #2789 (comment) |
pared
approved these changes
Nov 18, 2019
efiop
suggested changes
Nov 19, 2019
| @@ -152,9 +152,9 @@ def makedirs(path, exist_ok=False, mode=None): | |||
| _makedirs(path, exist_ok=exist_ok) | |||
| return | |||
|
|
|||
| umask = os.umask(0) | |||
| umask = os.umask(0o777 - mode) | |||
There was a problem hiding this comment.
Let's put a comment explaining what is going on :)
| def test_makedirs_permissions(): | ||
| dir_mode = 0o755 | ||
| intermediate_dir = "ΡΠ΅ΡΡΠΎΠ²Π°Ρ-Π΄ΠΈΡΠ΅ΠΊΡΠΎΡΠΈΡ" | ||
| test_dir = os.path.join(intermediate_dir, "data") |
There was a problem hiding this comment.
You are creating this directory in the project's root, which is not nice. Please use tmpdir fixture or something like that.
There was a problem hiding this comment.
good point, simplified using tmpdir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2789
β Have you followed the guidelines in the Contributing to DVC list?
π Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
β Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addresses. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. π