dvc: add Repo(skip_checks) flag #3490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
reviewed
Mar 17, 2020
Will skip modified graph checks on add, run and import. The aim is to avoid collecting stages and building graph on these commands. The skip_checks flag is aimed to be private, but let people use dvc on big repos without monkey patching or writing yaml files themselves.
efiop
reviewed
Mar 19, 2020
skshetry
approved these changes
Mar 23, 2020
skshetry
reviewed
Mar 23, 2020
|
Should be good to go. |
efiop
reviewed
Mar 23, 2020
tests/unit/repo/test_repo.py
Outdated
Comment on lines
91
to
94
| mocker.patch( | ||
| "dvc.repo.Repo._collect_graph", | ||
| side_effect=Exception("Should not collect"), | ||
| ) |
There was a problem hiding this comment.
It would be better to just assert that this wasn't called rather than putting this exception here, as we might have some logic catching this in our code (yes, we don't do that now and catching Exception is a bad thing, but still), which would result in a faulty test. Plus it would be more explicit to use assert not m.called rather than this unnecessary hack.
efiop
reviewed
Mar 23, 2020
| ) | ||
| dvc._skip_graph_checks = True | ||
|
|
||
| tmp_dir.gen("foo", "foo text") |
There was a problem hiding this comment.
Also you have dvc_gen above. Not sure if it is intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will skip modified graph checks on add, run and import. The aim is to
avoid collecting stages and building graph on these commands.
The skip_checks flag is aimed to be private, but let people use dvc on
big repos without monkey patching or writing yaml files themselves.
Closes #2671. For the time being.