Add more test decorators #669
Conversation
| @need_aws_auth | ||
| @long | ||
| def test_loading_remote(s3_tmp_path, s3_storage_fs): | ||
| project = s3_tmp_path("remote_conf") |
There was a problem hiding this comment.
Looks good, thank you @aminalaee. This should make it easier contributing 🙏🏻 The only question - I thought some tests with aws will pass since to read test bucket, you don't need any special permissions. Is this wrong?
There was a problem hiding this comment.
Not sure the case, but boto3.Session().get_credentials() will return None if the AWS credentials ~/.aws/credentials doesn't exist on my local. I guess this is even before making the calls to AWS services.
But about the failing tests, no, they failed with permission errors I think.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #669 +/- ##
=======================================
Coverage 85.75% 85.75%
=======================================
Files 109 109
Lines 9922 9922
=======================================
Hits 8509 8509
Misses 1413 1413 ☔ View full report in Codecov by Sentry. |
Not sure if this is accepted but some tests fail locally when credentials/env variables are not set.
I see that there are already decorators for this purpose, this PR extends those decorators.