Handle missing password #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dberenbaum
commented
Jul 8, 2024
tests/test_dulwich.py
Outdated
| @@ -8,15 +8,78 @@ | |||
| import asyncssh | |||
| import paramiko | |||
| import pytest | |||
| from dulwich.contrib.test_paramiko_vendor import CLIENT_KEY, PASSWORD, USER, Server | |||
There was a problem hiding this comment.
Unfortunately, this test was moved outside of dulwich, so we have to copy all these into this test file now. See https://github.com/jelmer/dulwich/pull/1277/files#diff-71d1213e4e666bc90d260326bcd0fe35137cc595cc108abe5eaf136440f2e9ab.
skshetry
previously approved these changes
Jul 8, 2024
|
@dberenbaum, please fix lint errors. Code looks good to me. |
dberenbaum
force-pushed
the
no-password
branch
2 times, most recently
from
9d01b22 to
733c599
Compare
|
Linting is fixed now. PTAL @skshetry, thanks! |
|
I think the force push dismissed your approval @skshetry |
skshetry
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty passwords were being passed as
()instead ofNoneto asyncssh, causing unexpected failure.See https://discuss.dvc.org/t/error-in-pushing-experiments/2138 and the added test for how to reproduce it.
In https://github.com/ronf/asyncssh/blob/050e5c1a0f42d5f145b44c33b183ff745447a687/asyncssh/connection.py#L7790, you can see that
usernamedefaults to(), butpassworddefaults toNone.