Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create output folder if it's not present #280

Closed
JorisAerts opened this issue Oct 23, 2020 · 2 comments
Closed

create output folder if it's not present #280

JorisAerts opened this issue Oct 23, 2020 · 2 comments
Assignees
@jimmyandrade
Labels
bug
Projects
webfont bug triage
Milestone
next

Comments

@JorisAerts
Copy link

If the output folder is not present, an error is thrown and the whole process is terminated.
@jimmyandrade jimmyandrade added this to Needs triage in webfont bug triage via automation Oct 23, 2020
@jimmyandrade jimmyandrade moved this from Needs triage to Low priority in webfont bug triage Oct 23, 2020
@jimmyandrade jimmyandrade added this to the next milestone Oct 23, 2020
Ghustavh97 added a commit to Ghustavh97/webfont that referenced this issue Nov 11, 2020
@Ghustavh97
feat(cli): create output folder if it's not present. (itgalaxy#280)
2567959 
Creates the destination/output folder if it is not preset and the
`--dest-create` flag is provided in the command.

I decided to make it a command instead of just creating the
folder just incase the provided destination path was a mistake or
a typo and you don't want your fonts to be exported there.
@Ghustavh97 Ghustavh97 mentioned this issue Nov 11, 2020
Closed
12 tasks
@jimmyandrade jimmyandrade self-assigned this Nov 11, 2020
webfont bug triage automation moved this from Low priority to Closed May 12, 2021
@jimmyandrade
Copy link
Collaborator

Hello @JorisAerts

This issue was fixed by @Ghustavh97 at d66a0d4 and released as Webfont 10.1.0, already available at npm.

@JorisAerts
Copy link
Author

Hello @JorisAerts

This issue was fixed by @Ghustavh97 at d66a0d4 and released as Webfont 10.1.0, already available at npm.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimmyandrade jimmyandrade

Labels
bug
Projects
webfont bug triage
Closed
Milestone
next
Development

Successfully merging a pull request may close this issue.

feat(cli): create output folder if it's not present. (#280) Ghustavh97/webfont
2 participants
@jimmyandrade @JorisAerts