Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): create output folder if it's not present. (#280) #307

Closed
wants to merge 3 commits into from

Conversation

Ghustavh97
Copy link
Contributor

Summary

Creates the destination/output folder if it is not preset and the
--dest-create flag is provided in the command.

I decided to make it a command instead of just creating the
folder just incase the provided destination path was a mistake or
a typo and you don't want your fonts to be exported there.

Proposed changes

This PR brings the following changes:

  • Add flag dist-create with alias m to cli

Related issue

Fixes #280

Dependencies added/removed (if applicable)

N/A


Testing

  • I have added or updated tests that prove my fix is effective or that my feature works (if applicable)
    • Unit test
    • Snapshot test
    • Manual test
    • Another test...

How to test

Describe the tests that you ran to verify your changes:

  1. Run npm test

Test configuration

  • Node.js version: v12.18.0
  • NPM version: 6.14.4

Checklist

  • I have added corresponding labels to this PR (like bug, enhancement...);
  • My commits follow the Conventional Commits 1.0 Guidelines;
  • My code follows the style guidelines of this project;
  • I have performed a self-review of my own code;
  • I have mapped technical debts found on my changes;
  • I have made corresponding changes to the documentation (if applicable);
  • My changes generate no new warnings or errors;

Creates the destination/output folder if it is not preset and the
`--dest-create` flag is provided in the command.

I decided to make it a command instead of just creating the
folder just incase the provided destination path was a mistake or
a typo and you don't want your fonts to be exported there.
@codecov-io
Copy link

codecov-io commented Nov 11, 2020

Codecov Report

Merging #307 (746c7b4) into master (2b4c1fb) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   92.09%   92.34%   +0.24%     
==========================================
  Files           2        2              
  Lines         215      222       +7     
  Branches       30       30              
==========================================
+ Hits          198      205       +7     
  Misses         17       17              
Impacted Files Coverage Δ
src/cli.js 85.41% <100.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b4c1fb...746c7b4. Read the comment docs.

@jimmyandrade jimmyandrade removed the request for review from alexander-akait November 26, 2020 15:18
@jimmyandrade jimmyandrade added this to the 10.0 milestone Nov 26, 2020
jimmyandrade pushed a commit that referenced this pull request May 12, 2021
Closes #280 #307

Co-Authored-By: Ghustavh <Ghustavh97@gmail.com>
@jimmyandrade
Copy link
Collaborator

jimmyandrade commented May 12, 2021

Hello @Ghustavh97

Your PR was merged at d66a0d4 and released as Webfont 10.1.0, already available at npm.

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create output folder if it's not present
4 participants