Skip to content

Conversation

dmitris
Copy link

@dmitris dmitris commented Dec 6, 2020

liked your solution! fixed a small typo in var name 😄

@ithinuel
Copy link
Owner

Thanks !

I updated the repo to add the License file.
If you agree to contribute under the same license (Apache 2.0), i'll be happy to merge your PR :D

@dmitris
Copy link
Author

dmitris commented Dec 18, 2020

thanks @ithinuel - I agree to place my (trivial) contribution under the project license, Apache 2.0 😄

@ithinuel
Copy link
Owner

ithinuel commented Jan 6, 2021

Arf, sorry about that conflict. Do you mind if I commit it and credit you in the commit log or do you prefer to rebase this PR ? :D

((sorry for that fuss but licenses blahblahblah TT )

liked your solution! fixed a small typo in var name 😄
@dmitris
Copy link
Author

dmitris commented Jan 12, 2021

rebased - thanks!

(if needed:
I agree to place my (trivial) contribution under the project license, Apache 2.0
)

@ithinuel ithinuel merged commit d4d8f4d into ithinuel:2020 Jan 12, 2021
@dmitris dmitris deleted the patch-1 branch January 12, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants