Fix: S3 pre signed uploads or similar binary stream uploads writing corrupt files #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a really good thing! Glad you find it out and fixed it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
RNFS is a great library to download and upload files. While trying to upload a file to S3 using a PreSigned
PUTurl, it was writing corrupt files as it was adding form boundary, meta data, etc to the file.Fix
binaryStreamOnly: A newly added field inUploadFileOptionswhich is defaulted tofalse.If this options is set
truethe uploader for RNFS will only write file binary data to the directed upload url. It omits all the meta data and form boundaries as they will write to the uploading stream essentially writing a corrupt file for the format provided.