Add conditional comments around methods not supported in Mac Catalyst #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I've added notes on the README that these functions won't be available on Mac Catalyst |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've successfully built and used
react-native-fson macOS 10.15 with the just-released Mac Catalyst. 🎉There was one slight issue: a couple of methods rely on deprecated iOS APIs (see https://developer.apple.com/documentation/photokit/phasset/1624782-fetchassetswithalasseturls). These APIs aren't supported under Mac Catalyst.
I don't know if it's worth fixing the methods (haven't used them myself), but at least there's an easy way to exclude them from the Catalyst build with conditional comments.
Thanks!