Invalid dependency resolution for neoforge mods (resolved forge mod)

[JohannesIBK]

The dependency resolution resolves a forge mod version that is cannot be loaded by neoforge, even tough a neoforge version is also available.

modrinth --projects="waystones:21.5.8+neoforge-1.21.5" --output-directory=/path/to/output --loader="neoforge" --game-version=1.21.5 --download-dependencies=REQUIRED

For this example, it resolves the balm-forge-1.21.5-21.5.20-all.jar which cannot be loaded by neoforge.

The solution is as simple as removing the forge compatibility in

mc-image-helper/src/main/java/me/itzg/helpers/modrinth/Loader.java

Line 10 in b24de72

neoforge("mods", forge),

but this may break exisiting installations (?) so I'm not sure on how to handle this.

[itzg]

It can only retrieve what the Modrinth API says and that is driven by the mod publishing data. Please double check their page for what they have designated.

I can also debug a little on my side.

Speaking of which it would be helpful to enable debug logging by setting the env var DEBUG to "true".

[itzg]

Oh, I see what's going on. Since NeoForge was/is newer, I have the dependencies lookup (when a specific file version isn't referenced) lookup both neoforge and forge loader types:

and the Forge file happens to be first.

I'm thinking it's what you suggested at first. It would be more complicated, but I could also have it try the specific loader first and only when missing try the compatible ones.

[itzg]

The latest mc-image-helper release and itzg/minecraft-server image include the fix for this. In the end went with the two step check of target loader and the then the compatible loader(s), if needed.