Pr/liven/fix placeholder subtitution #531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cidentally similar to placeholder
…umentException (Illegal group reference)
itzg
approved these changes
Feb 26, 2025
Comment on lines
+44
to
+46
| if (replacement == null) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Very good to know, that simply not calling appendReplacement effectively leaves that matched section unaltered.
|
Included in https://github.com/itzg/mc-image-helper/releases/tag/1.41.2 That can now be bumped here: |
|
I went ahead and created a PR to bump the version. |
Sorry I don't really understand what I'm supposed to do? It's not like I can approve PR in those repo or something? |
|
Nothing needed. I was just letting you know so you wouldn't create a duplicate PR. |
|
Oh okay. 10q |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request fixes the first part of the issue #530
I added test and fix fallback logic.
I'm going to look into second part as well. You're wellcome to give feedback and ideas. I'm looking forward to it actually.