Include Folia in results file #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't remember off hand why that was needed other than ensuring a specific TYPE was available for the image scripts downstream from Modrinth modpack install. Setting it to the requested type, paper, folia, etc seems like it would have been fine. In fact, setting FAMILY seems like it would have been just as helpful. |
|
Didn't want to change ResultsFileWriter too much so I this should just have it set the type to the uppercase of project |
itzg
approved these changes
Jun 9, 2025
kingcavespider1
added a commit
to kingcavespider1/mc-image-helper
that referenced
this pull request
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install paper hardcodes type to PAPER, not sure if just removing that is the best idea but if you a recommended way of doing it I can implement that