Update ForgeInstallerResolver.java to have update promotions URL

[MattFellows]

No description provided.

[nickstrijbos]

@itzg can this please be approved? :)

[itzg]

Thanks!

[itzg]

@itzg can this please be approved? :)

Yep, I just woke up 😀

[LexManos]

Ya, finding the random old urls that people are still using is fun..
For note the files.minecraftforge.net/maven/X urls have been redirecting to maven.minecraftforge.net/X and files.minecraftforge.net/X for over 5 years now. So worth the change.

But, I have fixed the redirects on our end so https://files.minecraftforge.net/maven/net/minecraftforge/forge/promotions_slim.json properly 301's again

Sorry, Wasn't an intentional break, just part of the process of rebuilding/cleaning up our servers.

[itzg]

Thanks @LexManos I really appreciate the context. Evolving URLs is a common thing the image code has to update for, so totally didn't see it as intentional breakage. Just business as usual 😀

With that said, I should really be more proactive to watch for announcements like this. I usually luck out and have someone log an issue when they see them.

[itzg]

FYI in #609 I'm enhancing the code to allow for those URLs to be configurable and the user agent will now correctly report itzg/mc-image-helper/{version} (cmd=install-forge)

[LexManos]

Sounds good, more config options is usually better.

I don't intend to ever change the url again. The whole point of moving the maven from files.mcf.net/maven to maven.mcf.net, so we could separate out the front end from the backend.

But, who knows what the future might bring.