Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitignore VSCode metadata #1183

Merged
merged 1 commit into from
Jul 28, 2022
Merged

gitignore VSCode metadata #1183

merged 1 commit into from
Jul 28, 2022

Conversation

kousu
Copy link
Contributor

@kousu kousu commented Jul 19, 2022

@kousu kousu requested a review from dyt811 July 19, 2022 20:04
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2700284272

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+9.8%) to 78.959%
Totals Coverage Status
Change from base Build 2666306672: 9.8%
Covered Lines: 4837
Relevant Lines: 6126
💛 - Coveralls

lifetheater57
lifetheater57 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@lifetheater57 lifetheater57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. Short. Simple. Useful.

@kousu kousu mentioned this pull request Jul 28, 2022
Merged
7 tasks
@kousu kousu merged commit f0511a3 into master Jul 28, 2022
@kousu kousu deleted the ng/block-vscode branch July 28, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lifetheater57 lifetheater57 lifetheater57 approved these changes

@dyt811 dyt811 Awaiting requested review from dyt811

Assignees

@kousu kousu

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kousu @coveralls @lifetheater57 @kanishk16