-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updater #603
Open
fodinabor
wants to merge
12
commits into
ivansafrin:master
Choose a base branch
from
fodinabor:Updater
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Updater #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for Polycode IDE.
… UNIX Sockets, updater no longer uses Events, UpdaterWindow closes correctly now.
…amically allocated buffers, threading.
…ng it binary file compatible by no longer using Strings but dynamically re-, allocated char buffers.
It now is able to get binary files (like images), but only as long as your memory is able to hold it.. HTTPFetcherEvent* hEvent = ((HTTPFetcherEvent*)event);
FILE* fileH = fopen("image.png", "wb");
size_t written = fwrite(hEvent->data, 1, hEvent->contentSize, fileH);
fclose(fileH); would write a png file (I tested it with several png and xcf files with sizes between 256kB and 26MB and a 100MB zip file) |
…ested data to a file. Using this for the Updater to directly download the new version into the IDE's directory.
…class from SettingsWindow.h. If no savePath is given it will save the fetched file to the same path as it is on the server if saving is turned on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ivansafrin we should talk about the binary download later - should I maybe use temp files instead of only storing everything in buffers?