Skip to content

Conversation

gmantele
Copy link
Collaborator

Add a recommendation to use UDFs listed in the PEN about a UDF catalogue
(Campillo and Demleitner, 2019 -
http://www.ivoa.net/documents/udf-catalogue/index.html).

This commit is a first attempt to fix issue #16

@gmantele
Copy link
Collaborator Author

I have added a new command in ivoa-cite.tex named \CatalogUDF which cite the PEN about the UDFs catalogue. However, there is no reference to this document in the repository ivoatex and more precisely in the file ivoabib.bib.

Is it because it is still a Proposed Endorsed Note, or just because it is an Endorsed Note?
Or is it just because this file is not up to date? If it is the case, how to update it? Am I allowed to?

@gmantele
Copy link
Collaborator Author

gmantele commented Jan 28, 2020

I added the following lines in my local ivoabib.bib:

@Misc{note:UDFCatalogue,
  author =       {Jon Juaristi Campillo and Markus Demleitner},
  title =        {Catalogue of {ADQL} User Defined Functions},
  howpublished = {{IVOA Note}},
  year =         {2019},
  month =        {September},
  url =          {http://www.ivoa.net/documents/udf-catalogue/index.html}
}

@jontxu
Copy link

jontxu commented Jan 28, 2020

Add a recommendation to use UDFs listed in the PEN about a UDF catalogue
(Campillo and Demleitner, 2019 -
http://www.ivoa.net/documents/udf-catalogue/index.html).

It should be Juaristi Campillo in any case. Both are surnames.

@gmantele
Copy link
Collaborator Author

It should be Juaristi Campillo in any case. Both are surnames.

Sorry for this mistake in your name. It is present only in my above comment which is also the commit description. Not sure I can fix the commit message that easily right now (without a push --force), but I will do it just before/after merging the PR.

However, in order to avoid this mistake in the ADQL document, I admit having no idea. It is automatically generated from the file ivoabib.bib where, as you can see above, I wrote all your first- and surnames. Maybe the person(s) who will tell me how this file can be updated will know how to fix that. Personally, I am really far from being a LaTeX expert :(

@msdemlei
Copy link
Contributor

I have added a new command in ivoa-cite.tex named \CatalogUDF which cite the PEN about the UDFs catalogue. However, there is no reference to this document in the repository ivoatex and more precisely in the file ivoabib.bib.

Is it because it is still a Proposed Endorsed Note, or just because it is an Endorsed Note?
Or is it just because this file is not up to date? If it is the case, how to update it? Am I allowed to?

Endorsed notes will be in ADS and then eventually in docrepo.bib.

As to who updates that... Well, on volute it was mostly me, when I chanced upon it, but really everyone could (type make docrepo.bib in ivoatex).

With the elaborate access control, possibly requiring branching and merging, that's planned for github... I frankly don't know. I could see volunteering for it, perhaps.

@msdemlei
Copy link
Contributor

I added the following lines in my local ivoabib.bib:

@Misc{note:UDFCatalogue,
  author =       {Jon Juaristi Campillo and Markus Demleitner},

Make Jon's name "Jon {Juaritsti Campillo}", and BibTeX will do the right thing.

@gmantele
Copy link
Collaborator Author

I added the following lines in my local ivoabib.bib:

@Misc{note:UDFCatalogue,
  author =       {Jon Juaristi Campillo and Markus Demleitner},

Make Jon's name "Jon {Juaritsti Campillo}", and BibTeX will do the right thing.

It works. Thanks.

@gmantele
Copy link
Collaborator Author

Endorsed notes will be in ADS and then eventually in docrepo.bib.

As to who updates that... Well, on volute it was mostly me, when I chanced upon it, but really everyone could (type make docrepo.bib in ivoatex).

This command erased the document docrepo.bib. There seems to be an error while querying ADS (I think they changed their API recently). Anyway, this Endorsed Note is not yet in ADS ; probably because it is still in Proposed state.

Any plan to update its status?
Should we wait for this to be updated before releasing ADQL-2.1?

@msdemlei
Copy link
Contributor

Any plan to update its status?
Should we wait for this to be updated before releasing ADQL-2.1?

No, we shouldn't wait. If ADQL 2.1 is ready, just put the note bibtex into a local.bib as per ivoatexDoc and be done with it.

However, given there's only three people left I have to get going for getting the UDF cat endorsed, I'd say there's an excellent chance we'll have it in docrepo.bib before you have to hand in ADQL 2.1's REC.

@gmantele
Copy link
Collaborator Author

I agree. I am quite confidente that the Endorsed Note will be ready before ADQL-2.1 goes REC.
So, for me, we can already merge this PullRequest....unless you, @msdemlei, say there is still something to do here to "enable the bibtext connection" correctly when the EN will be ready? I admit, I am really not familiar at all with all these latex/bibtex things :S

@msdemlei
Copy link
Contributor

msdemlei commented Oct 23, 2020 via email

@gmantele
Copy link
Collaborator Author

Ok. Thank you for the info.

So, instead of writing a TODO in the doc, I would prefer to keep this PullRequest open until that time. In that way, no risk to forget about it as this PullRequest and corresponding Issue will still be visibly open.

@gmantele gmantele added this to the 2.1 milestone Oct 23, 2020
@gmantele gmantele force-pushed the issue-16-udf-catalogue branch from b809529 to e60665c Compare May 14, 2021 16:50
@gmantele
Copy link
Collaborator Author

Now that the Catalogue UDF note is a PEN, I think it should be now possible to complete this PullRequest. @msdemlei do you know how I can now reference this note properly? I tried `make docrepo.bib' on my side, but still get an error, and I admit I don't really get how this works. Should not it be updated in the GitHub repo ivoatex directly (and then I update my sub-project pointing to to ivoatex)? If so, I don't see this note in the file docrepo.bib of this repo.

@msdemlei
Copy link
Contributor

msdemlei commented May 17, 2021 via email

@gmantele
Copy link
Collaborator Author

Thank you @msdemlei (sorry, I have not seen your message before today). It now works as expected 😎

So, if everything is fine for everybody, I think we can now finally merge and close this PullRequest.

Copy link
Member

@molinaro-m molinaro-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks OK to me.

@gmantele gmantele merged commit b7849f5 into ivoa-std:master May 26, 2021
@gmantele gmantele deleted the issue-16-udf-catalogue branch June 1, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants