Accept NULL value wherever a value is expected #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem raised on the ADQL validator project: ivoa/lyonetia#16 (comment)
msdemlei
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
Technically, this is what DaCHS has been doing for many years, and so I don't expect any trouble.
I have not specifically searched the document for any other places that might need changes as a result, but I'm confident you found them all. So: As far as I am concerned, let's merge this.
|
If nobody complains about this PullRequest, can anyone with appropriate permissions review and merge it, please? |
|
On Fri, Feb 03, 2023 at 07:57:19AM -0800, Grégory Mantelet wrote:
If nobody complains about this PullRequest, can anyone with
appropriate permissions review and merge it, please?
Gah... I think as DAL vice chair, you should be able to force-merge,
or to give me write permission, in which case my review should count.
If you can't manage the ADQL repo, something is wrongly set up and
I'm afraid you have to ask Pat.
But I give you our (IVOA's) permission system needs more thought &
work. And we probably should have an appointed steward just like we
have the document coordinator...
|
|
I cannot review and merge my own PullRequest, even as both the main author of the ADQL standard and the DAL vice-chair. |
mbtaylor
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem raised on the ADQL validator project:
ivoa/lyonetia#16 (comment)
NULL is not allowed anywhere else than in
IS [NOT] NULLandCAST(...). In all DBMS, NULL is valid value in almost all places where a value is expected. This is actually a miss in ADQL-2.0. This Pull-Request aims to fix this issue. An Erratum will be added to ADQL-2.0 document.