Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/apply 1178 optional working preferences questions #1206

Merged

Conversation

KoWeiJAC
Copy link
Contributor

@KoWeiJAC KoWeiJAC commented Jul 31, 2024

What's included?

Closes #1178

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Include screen grabs, notes etc.


PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Jul 31, 2024

Visit the preview URL for this PR (updated for commit 8f7d5e8):

https://jac-apply-develop--pr1206-fix-apply-1178-optio-vzh8kxoo.web.app

(expires Fri, 30 Aug 2024 15:02:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d5ac0a9c931657844a433a502135cf38aca21627

Copy link

@NormaJAC NormaJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KoWeiJAC for V1, none of the questions were optional or mandatory, is it supposed to say whether they're mandatory or optional? Am I missing something? All the V2 questions were ok.
image

image image

@KoWeiJAC
Copy link
Contributor Author

KoWeiJAC commented Aug 5, 2024

@NormaJAC
For V1, based on test and code, it seems there's no mandatory settings on the admin site, the mandatory settings are fixed on apply site:

  • Location preference: optional
  • Jurisdiction preferences: mandatory
  • Additional preferences: mandatory

@warrensearle warrensearle removed their request for review August 5, 2024 10:53
@HalcyonJAC HalcyonJAC merged commit 300e822 into main Aug 5, 2024
12 of 13 checks passed
@HalcyonJAC HalcyonJAC deleted the fix/apply-1178-optional-working-preferences-questions branch August 5, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional working preferences questions appear as mandatory on Apply
6 participants