Skip to content

Conversation

jacebrowning
Copy link
Owner

Removed deprecated settings.

Removed deprecated settings.
@jacebrowning
Copy link
Owner Author

@joshfriend I think you'll appreciate this change. Should the generated instructional comments in .pylintrc be kept? What about the default options?

@joshfriend
Copy link
Collaborator

Instructional comments are probably helpful to keep. Have you tried the default options on another project (like dornerworks/arniepye)? Did pylint errors start popping up?

@jacebrowning
Copy link
Owner Author

@joshfriend by "default options" I meant that the generated .pylintrc includes every option that was set internally (nearly all of these are the default values, such as https://github.com/jacebrowning/template-python/pull/22/files#diff-d6d3d73911fd3ad6f39e4027f763b307R120). I'm inclined to remove these "explicitly set default options" unless a default chosen to be overridden.

@joshfriend
Copy link
Collaborator

👍

The defaults can be changed on a per project basis or in this template
if later justified. I also re-enabled R0801 (similar lines) because I
couldn’t remember why it was getting annoying.
@jacebrowning
Copy link
Owner Author

@joshfriend how's that?

joshfriend added a commit that referenced this pull request May 15, 2014
Move Pylint settings to .pylintrc
@joshfriend joshfriend merged commit e33e3fc into master May 15, 2014
@jacebrowning jacebrowning changed the title Move Pylint settings to .pylintrc Move Pylint settings to .pylintrc Nov 9, 2014
juneqch pushed a commit to profilech/.cookiecutter-template-python that referenced this pull request Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants