Add python2 to build matrix #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@joshfriend can you explain what happens when TRAVIS is not defined?
There was a problem hiding this comment.
In the Travis build environment .travis.yml handles what the current version of the python executable is. When building locally, the python version can be selected using the PYTHON_MAJOR and PYTHON_MINOR environment variables, or by just setting the version explicitly here.
|
@joshfriend this all looks good. Want to merge my change from |
|
@jacebrowning done. |
jacebrowning
added a commit
that referenced
this pull request
Oct 30, 2014
Add python2 to build matrix
juneqch
added a commit
to profilech/.cookiecutter-template-python
that referenced
this pull request
Jun 8, 2018
Add python2 to build matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently nothing about the template that makes it python3 only, so why not officially declare support for python2?