Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jack2 impulse_grabber.c #13

Merged
merged 5 commits into from
Dec 30, 2021
Merged

Jack2 impulse_grabber.c #13

merged 5 commits into from
Dec 30, 2021

Conversation

dvzrv
Copy link
Collaborator

@dvzrv dvzrv commented Nov 25, 2021

example-clients/impulse_grabber.c:
Merge in the jack2 version of impulse_grabber.c as the initial file has
been introduced in a modified form (not using the original
example-clients file), which does not allow for the jack2 version of the
file to be rebased on top of the original file (without it being first
removed).

Relates to #9

example-clients/impulse_grabber.c:
Remove impulse_grabber.c, as its jack2 pendant has been introduced in a
modified form to the jack2 repository. This does not allow for a clean
rebase on top of the original file.
@dvzrv dvzrv added the enhancement New feature or request label Nov 25, 2021
@dvzrv dvzrv requested a review from falkTX November 25, 2021 14:40
@dvzrv dvzrv self-assigned this Nov 25, 2021
@@ -192,6 +200,12 @@ main (int argc, char *argv[])

free (ports);

/* install a signal handler to properly quits jack client */
signal(SIGQUIT, signal_handler);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another case of tabs vs spaces, will fix after merge too

@falkTX falkTX merged commit 2d61777 into main Dec 30, 2021
@falkTX falkTX deleted the jack2_impulse_grabber branch December 30, 2021 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants