Jack2 iodelay.cpp #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tools/iodelay.c: Remove the original iodelay.c as the jack2 variant had been imported to another location (with added modifications and shifting names), making a rebase impossible.
26 tasks
git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@1205 0c269be4-1314-0410-8aa9-9f06e86f4224
git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@2270 0c269be4-1314-0410-8aa9-9f06e86f4224
…if clients are actually realtime, that is have setup any of the RT callback. git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@2279 0c269be4-1314-0410-8aa9-9f06e86f4224
git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@3119 0c269be4-1314-0410-8aa9-9f06e86f4224
git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@3120 0c269be4-1314-0410-8aa9-9f06e86f4224
git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@4159 0c269be4-1314-0410-8aa9-9f06e86f4224
git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@4163 0c269be4-1314-0410-8aa9-9f06e86f4224
git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@4488 0c269be4-1314-0410-8aa9-9f06e86f4224
git-svn-id: http://subversion.jackaudio.org/jack/jack2/trunk/jackmp@4489 0c269be4-1314-0410-8aa9-9f06e86f4224
jack_latency_range_t is
struct _jack_latency_range {
jack_nframes_t min;
jack_nframes_t max;
};
and jack_nframes_t is
typedef uint32_t jack_nframes_t;
so it's unsigned. Initialising it with -1 is invalid (at least in C++14). We cannot use {0, 0}, because latency_cb has
jack_latency_range_t range;
range.min = range.max = 0;
if ((range.min != capture_latency.min) || (range.max !=
capture_latency.max)) {
capture_latency = range;
}
so we must not have {0, 0}, otherwise the condition would never be true.
Using UINT32_MAX should be equivalent to the previous -1.
With glibc 2.16, we get following build error when building jack2: [193/247] cxx: tests/iodelay.cpp -> build/tests/iodelay.cpp.4.o ../tests/iodelay.cpp:171:43: error: 'UINT32_MAX' was not declared in this scope ../tests/iodelay.cpp:171:55: error: 'UINT32_MAX' was not declared in this scope ../tests/iodelay.cpp:172:44: error: 'UINT32_MAX' was not declared in this scope ../tests/iodelay.cpp:172:56: error: 'UINT32_MAX' was not declared in this scope In glibc 2.17 or older version, Header <stdint.h> defines these macros for C++ only if explicitly requested by defining __STDC_LIMIT_MACROS. We can't use <cstdint> since it requires C++11 standard. This build issue found by Buildroot autobuilder. http://autobuild.buildroot.net/results/369/369ce208ffea43dad75ba0a13469159b341e3bf5/ Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
tools/meson.build: Adapt meson build file to rename of tools/iodelay.c to tools/iodelay.cpp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add jack2 variant of tools/iodelay.c, iodelay.cpp, which had been
imported to a different location with additional modifications, which
makes a simple rebase impossible.
Adapt meson build file to rename of tools/iodelay.c to
tools/iodelay.cpp.
Relates to #9