Remove usage of 'U' mode bit for opening files in python #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'U' mode bit is removed in python 3.11. It has been deprecated for a long time. The 'U' mode bit has no effect so this change doesn't change any behavior. See https://docs.python.org/3.11/whatsnew/3.11.html#changes-in-the-python-api
|
This issue was addressed by waf upstream 3 years ago: https://gitlab.com/ita1024/waf/-/commit/68997828c850ce7fb30b73b4adfde35053e539d1 Upgrading waf to latest should fix the py3.11 incompatibility. |
6 tasks
|
Blocking Homebrew/homebrew-core#119011 |
|
We do indeed need to update waf, but needs to be done carefully as there are custom changes in there. And I think extra modules too. So thanks, merging now! |
|
Can we please get a release of jack2 because this is one of the installs that is blocking Homebrew's upgrade to Python 3.11 as the default Python? |
|
If we manage to fix #869 then it would make sense to get a release out. Any help for that one is greatly appreciated! |
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Feb 10, 2023
Fixes: http://autobuild.buildroot.net/results/5ce/5ce5ebd20e0e509b31b51d2ec1aed56fdb8f45aa/ The bundled waf script is too old (2.0.12) for python >= 3.11 as it uses the 'U' modifier to open (universal newlines), which have been deprecated since python 3.3 and finally removed in 3.11. Jack unfortunately uses a modified waf, so we cannot just set JACK2_NEEDS_EXTERNAL_WAF, so instead backport an upstream patch fixing the compatibility issue: jackaudio/jack2#884 Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'U' mode bit is removed in python 3.11. It has been
deprecated for a long time. The 'U' mode bit has no effect
so this change doesn't change any behavior.
See https://docs.python.org/3.11/whatsnew/3.11.html#changes-in-the-python-api