Bugfix for ROBODoc documentation generation with CMake #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All edits done, ready to pull |
- Products of the custom command to generate documentation were not properly listed - Now, make clean will clean the documentation directory without use of `set_directory_properties()` - ROBODoc outputs dynamically computed at CMake configuration time. Fixes jacobwilliams#17 - Change in ROBODoc Headers or new source files will no longers require manual update of the outputs
jacobwilliams
added a commit
that referenced
this pull request
Jun 19, 2014
Bugfix for ROBODoc documentation generation with CMake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significant change
The
foreach()loop was overwriting theROBO_OUTPUTSvariable instead of adding the directory and concatenating list elements. This resulted in CMake not knowing which files are produced (and need to be removed onmake clean) and could have led to dependency resolution issues down the road.The outputs of the ROBODoc generation are now dynamically computed at CMake configure time. (The foreach loop is removed completely.) This generates a list of outputs including full paths.
minor changes
libsubdirectory of the build treedoctodocumentation