New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default phase for goal "report" should be "verify" #72

Closed
Godin opened this Issue Jan 14, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@Godin
Member

Godin commented Jan 14, 2013

Thus all JaCoCo goals would be bound to default phase.

@mfriedenhagen

This comment has been minimized.

Show comment
Hide comment
@mfriedenhagen

mfriedenhagen Jan 25, 2013

Member

Hello Godin,
just a question:

  • why did you choose prepare-package as default?
  • I see that this is needed e.g., to get Netbeans' Codecoverage tooling to work properly.
  • On the other a lot of people (at least in the company where I work) like to include coverage coming from integration-tests as well, so verify could be a (default) candidate as well :-).

Best Regards
Mirko

Member

mfriedenhagen commented Jan 25, 2013

Hello Godin,
just a question:

  • why did you choose prepare-package as default?
  • I see that this is needed e.g., to get Netbeans' Codecoverage tooling to work properly.
  • On the other a lot of people (at least in the company where I work) like to include coverage coming from integration-tests as well, so verify could be a (default) candidate as well :-).

Best Regards
Mirko

@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Feb 2, 2013

Member

@mfriedenhagen Ok, you convinced me - I'll change default phase on "verify".

Member

Godin commented Feb 2, 2013

@mfriedenhagen Ok, you convinced me - I'll change default phase on "verify".

@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.