Inconsistent stackmap frames for TwoWord arguments #85

Closed
marchof opened this Issue Mar 1, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@marchof
Member

marchof commented Mar 1, 2013

Inserted frames are incorrect in the following situation:

  • At least one method argument is TwoWord (long or double)
  • A stackmap frame does not contain these arguments as local variables (not used any more).

These situations do not occure with the Java compiler, but with certain tools. See issue jacoco/eclemma#46

In this case the number of Top elements which need so be inserted before the probe variable is too small as the TwoWord size is not properly considered.

marchof added a commit that referenced this issue Mar 1, 2013

Fixed inconsistent stackmap frames when instrumenting class files
produced by certain tools like ProGuard (GitHub #85).

@marchof marchof closed this Mar 1, 2013

@drangor

This comment has been minimized.

Show comment
Hide comment
@drangor

drangor Mar 11, 2013

Apologies for the delay in testing this, I've been on hols.

The latest snapshot fixes the problems I had, both in the small test project and the original library where I encountered it. Thanks for the quick fix Marchof. Looking forward to the 0.6.3 release.

drangor commented Mar 11, 2013

Apologies for the delay in testing this, I've been on hols.

The latest snapshot fixes the problems I had, both in the small test project and the original library where I encountered it. Thanks for the quick fix Marchof. Looking forward to the 0.6.3 release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.