Skip to content

Apply fixes from StyleCI #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2018
Merged

Apply fixes from StyleCI #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions src/Traits/SmartLoad.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,23 +240,22 @@ public function networks()
* @param string $clientReference
* @param string $smsRecipientMsisdn
* @param string $deviceId
* @param integer $productId
* @param integer $amount
* @param boolean $pinless
* @param boolean $sendSms
* @param int $productId
* @param int $amount
* @param bool $pinless
* @param bool $sendSms
*
*
{
"smartloadId": "27821234567",
"clientReference": "abc123",
"smsRecipientMsisdn": "27821234567",
"deviceId": "27821234567",
"productId": 62,
"amount": 12,
"pinless": true,
"sendSms": true
}

* {
* "smartloadId": "27821234567",
* "clientReference": "abc123",
* "smsRecipientMsisdn": "27821234567",
* "deviceId": "27821234567",
* "productId": 62,
* "amount": 12,
* "pinless": true,
* "sendSms": true
* }
*/
public function prevend()
{
Expand Down Expand Up @@ -298,7 +297,7 @@ public function prevend()
/**
* Authenticate and retrieves a list of all available networks.
*
* @param integer $id
* @param int $id
*
* @throws Exception
*
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/BalanceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public function testBalanaceNotOurDealerMsisdn()
self::assertEquals('error', $response['status']);
self::assertEquals(403, $response['http_code']);
self::assertInstanceOf('\StdClass', $response['body']);
$expected = new \StdClass;
$expected = new \StdClass();
$expected->code = 400;
$expected->message = 'The supplied Smartload ID is not registered to your account';

Expand All @@ -94,7 +94,7 @@ public function testBalanaceInvalidToken()
self::assertEquals('error', $response['status']);
self::assertEquals(401, $response['http_code']);
self::assertInstanceOf('\StdClass', $response['body']);
$expected = new \StdClass;
$expected = new \StdClass();
$expected->responseDescription = 'Authorization denied. Token validation failed';
$expected->accessToken = null;
$expected->tokenType = null;
Expand Down