New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump idl with zipkin swagger and messaging annos #533

Merged
merged 1 commit into from Nov 13, 2017

Conversation

Projects
None yet
3 participants
@pavolloffay
Member

pavolloffay commented Nov 13, 2017

  • updated idl to master/head
  • run make thrift
Bump idl with zipkin swagger and messaging annos
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 13, 2017

Coverage Status

Coverage increased (+0.05%) to 100.0% when pulling ff3e590 on pavolloffay:bump-idl-zipkin-swagger into 32e2cd3 on jaegertracing:master.

coveralls commented Nov 13, 2017

Coverage Status

Coverage increased (+0.05%) to 100.0% when pulling ff3e590 on pavolloffay:bump-idl-zipkin-swagger into 32e2cd3 on jaegertracing:master.

@@ -43,6 +43,10 @@ func (c *tchanBaggageRestrictionManagerClient) GetBaggageRestrictions(ctx thrift
}
success, err := c.client.Call(ctx, c.thriftService, "getBaggageRestrictions", &args, &resp)
if err == nil && !success {
switch {

This comment has been minimized.

@black-adder

black-adder Nov 13, 2017

Collaborator

this looks fine but it's weird this got generated given that these thrift files haven't changed and we're always used thrift 0.9.3 to generate them. Maybe they patched something into 0.9.3 recently since it does seem like the docker image was updated: https://hub.docker.com/r/library/thrift/tags/

@black-adder

black-adder Nov 13, 2017

Collaborator

this looks fine but it's weird this got generated given that these thrift files haven't changed and we're always used thrift 0.9.3 to generate them. Maybe they patched something into 0.9.3 recently since it does seem like the docker image was updated: https://hub.docker.com/r/library/thrift/tags/

This comment has been minimized.

@pavolloffay

pavolloffay Nov 13, 2017

Member

It's weird I don't know why it's changed. I have used a standard make target.

@pavolloffay

pavolloffay Nov 13, 2017

Member

It's weird I don't know why it's changed. I have used a standard make target.

@pavolloffay pavolloffay merged commit e0a74f2 into jaegertracing:master Nov 13, 2017

3 checks passed

DCO All commits have a DCO sign-off from the author
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 100.0%
Details

@wafflebot wafflebot bot removed the review label Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment