Bump idl with zipkin swagger and messaging annos #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
requested review from
black-adder,
vprithvi and
yurishkuro
as code owners
ghost
assigned 
black-adder
approved these changes
Nov 13, 2017
| @@ -43,6 +43,10 @@ func (c *tchanBaggageRestrictionManagerClient) GetBaggageRestrictions(ctx thrift | |||
| } | |||
| success, err := c.client.Call(ctx, c.thriftService, "getBaggageRestrictions", &args, &resp) | |||
| if err == nil && !success { | |||
| switch { | |||
There was a problem hiding this comment.
this looks fine but it's weird this got generated given that these thrift files haven't changed and we're always used thrift 0.9.3 to generate them. Maybe they patched something into 0.9.3 recently since it does seem like the docker image was updated: https://hub.docker.com/r/library/thrift/tags/
There was a problem hiding this comment.
It's weird I don't know why it's changed. I have used a standard make target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make thrift