Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change maintainer nominations to public #534

Merged
merged 2 commits into from
Nov 14, 2017
Merged

Change maintainer nominations to public #534

merged 2 commits into from
Nov 14, 2017

Conversation

yurishkuro
Copy link
Member

Resolves #531

Change maintainer nominations to public
9f77986 
Signed-off-by: Yuri Shkuro <ys@uber.com>
@ghost ghost assigned yurishkuro Nov 13, 2017
@ghost ghost added the review label Nov 13, 2017
black-adder
black-adder reviewed Nov 13, 2017
View reviewed changes
GOVERNANCE.md Outdated
(please do not CC the nominee on the nomination email) containing the following information:
A new maintainer must be proposed by an existing maintainer by sending a message to the
[jaeger-tracing@googlegroups.com](https://groups.google.com/forum/#!forum/jaeger-tracing)
mail list containing the following information:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/mail/mailing ?

Address comments
4683488 
Signed-off-by: Yuri Shkuro <ys@uber.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 99.954% when pulling 4683488 on governance-public into e0a74f2 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4683488 on governance-public into e0a74f2 on master.

@yurishkuro yurishkuro merged commit 704cdbd into master Nov 14, 2017
@ghost ghost removed the review label Nov 14, 2017
@yurishkuro yurishkuro deleted the governance-public branch December 23, 2017 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavolloffay pavolloffay pavolloffay approved these changes

@black-adder black-adder black-adder approved these changes

@vprithvi vprithvi Awaiting requested review from vprithvi

Assignees

@yurishkuro yurishkuro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yurishkuro @coveralls @black-adder @pavolloffay